Fix ?contact command bug where the channel is created inside random category.
#3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… category when `silent` or `silently` is passed in. Resolve modmail-dev#3091
|
@fourjr - Is there any chance we can get this merged into master soon, so we can fix a historical issue on our implementation? |
jcharlesl
added a commit
to jcharlesl/modmail
that referenced
this pull request
May 3, 2022
…d admins will be able to contact a user silently whilst having their own separate category. Fixed issue modmail-dev#3092 along with a discovered issue with privacy in mind.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR:
?contactcommand bug where the bot creates the thread channel inside a random category ifsilentorsilentlyis passed in the command.Resolve #3091
The cause of the issue is, there's a possibility an empty string is passed when converting the category using the
SimilarCategoryConverterthat makes the converter returns any category it found first.I think the solution in this PR is dynamic enough to deal with that and user inputs.