Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

input-groups are using wrong class and markup #91

Open
cadu-leite opened this issue Mar 12, 2018 · 2 comments
Open

input-groups are using wrong class and markup #91

cadu-leite opened this issue Mar 12, 2018 · 2 comments

Comments

@cadu-leite
Copy link

cadu-leite commented Mar 12, 2018

the actual makup at app/forms/input-groups.hbs is

    <div class="input-group">
        <span class="input-group-addon">$</span>
        <input type="text" class="form-control" placeholder="Some text here">
        <span class="input-group-addon">.00</span>  <!- input-group-addon class is no more -->
    </div>

when I believe it should be

    <div class="input-group">
        <div class="input-group-prepend">  <!-  for prepend - need a outer div.input-group-XXXX -->
            <span class="input-group-text">@</span> <!-  input-group-text is the new class -->
        </div>
        <input type="text" class="form-control" placeholder="Some text here">
    </div>

    <div class="input-group">
        <input type="text" class="form-control" placeholder="Input with append text">
        <div class="input-group-append">  <!-  for append -->
            <span class="input-group-text">.00</span>
        </div>
    </div>

this is not the look&feel it should have

screen shot 2018-03-12 at 16 52 06

@cadu-leite cadu-leite changed the title input groups wrong class and markup input-groups are using wrong class and markup Mar 12, 2018
@modularcoder
Copy link
Member

@cadu-leite thanks a lot!
Will try to fix this as soon as possible.
Or can you make a pull request for this fix?

Thanks!

@cadu-leite
Copy link
Author

sure ... Glad to help
... may I'll take some time ... finishing a demo @ my job.

cadu-leite pushed a commit to cadu-leite/modular-admin-html that referenced this issue Mar 15, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants