Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add hook for removing tinymce instance #84

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Add hook for removing tinymce instance #84

merged 1 commit into from
Jul 28, 2023

Conversation

howdu
Copy link
Contributor

@howdu howdu commented Jul 28, 2023

Fix an issue when using TinyEditor inside a repeater and you add/remove the repeater item.

Forms\Components\Repeater::make('test')
  ->schema([
      TinyEditor::make('editor')
  ])
Screen.Recording.2023-07-28.at.13.45.45.mov

With fix

Screen.Recording.2023-07-28.at.13.47.31.mov

Fix an issue when using inside a repeater
@howdu howdu changed the title Add hook for removing tinyce instance Add hook for removing tinymce instance Jul 28, 2023
@mohamedsabil83
Copy link
Owner

Before this, update to the latest version and force push the assets and try

@howdu
Copy link
Contributor Author

howdu commented Jul 28, 2023

Yes using version v1.7.4 and ran php artisan vendor:publish --tag="filament-forms-tinyeditor-assets" --force

@mohamedsabil83
Copy link
Owner

I can't reproduce your issue but as it is fixed I'll merge it

@mohamedsabil83 mohamedsabil83 merged commit 032be72 into mohamedsabil83:main Jul 28, 2023
17 checks passed
@mohamedsabil83
Copy link
Owner

Thank you. Let me know if everything works as expected.

@howdu howdu deleted the patch-1 branch July 30, 2023 15:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants