Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove support for v1 timestamps file #5

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

moi15moi
Copy link
Owner

Currently, we don't correctly support v1 timestamps. When the timestamps is over the last range, we have some rounding issue.

See the function "test_frame_to_time_v1" of the file tests\test_text_file_timestamps.py for an example.

Currently, we don't correctly support v1 timestamps.
When the timestamps is over the last range, we have some rounding issue.

See the function "test_frame_to_time_v1" of the file tests\test_text_file_timestamps.py for an example.
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (f9f1b64) to head (0bd62f3).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   97.35%   97.98%   +0.62%     
==========================================
  Files          16       16              
  Lines        1438     1288     -150     
==========================================
- Hits         1400     1262     -138     
+ Misses         38       26      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moi15moi moi15moi merged commit d36ae1d into main Dec 16, 2024
15 checks passed
@moi15moi moi15moi deleted the Remove-support-for-v1-timestamps-file branch December 18, 2024 01:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants