Fix failing tests

moi90 · Dec 26, 2023 · b92935f · b92935f
1 parent e9c7073
commit b92935f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/experitur/core/configurators.py b/experitur/core/configurators.py
@@ -818,7 +818,7 @@ class Clear(Configurator):
         *names (str): Parameter names to remove from the configuration.
     """
 
-    __str_attrs__ = ("names",)
+    __str_attrs__ = ("patterns",)
 
     def __init__(self, *patterns: str):
         self.patterns = patterns

diff --git a/experitur/core/trial.py b/experitur/core/trial.py
@@ -1511,9 +1511,9 @@ def filter(self, fn: Callable[[Trial], bool]) -> "TrialCollectionGroupby":
 
         return TrialCollectionGroupby({k: v.filter(fn) for k, v in self.groups.items()})
 
-    def best_n(self, n, minimize: Objective = None, maximize: Objective = None):
+    def best_n(self, n, *, minimize: Objective = None, maximize: Objective = None):
         return TrialCollectionGroupby(
-            {k: v.best_n(n, minimize, maximize) for k, v in self.groups.items()}
+            {k: v.best_n(n, minimize=minimize, maximize=maximize) for k, v in self.groups.items()}
         )
 
     def pareto_optimal(self, minimize: Objective = None, maximize: Objective = None):

diff --git a/tests/core/test_trial.py b/tests/core/test_trial.py
@@ -196,7 +196,7 @@ def raising_fun(*_, **__):
 
             with pytest.raises(
                 SpecialException,
-                match=re.escape("Error calling"),
+                match=re.escape(""),
             ):
                 trial.prefixed("__empty1c_").call(raising_fun)