Refactored current show locked fade overlay logic #64
+121
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moinm3uw
changed the title
JanSeliv
requested changes
Mar 13, 2025
Source/ProgressionSystemRuntime/Public/Widgets/PSOverlayWidget.h
Outdated
Show resolved
Hide resolved
Source/ProgressionSystemRuntime/Public/Widgets/PSOverlayWidget.h
Outdated
Show resolved
Hide resolved
Source/ProgressionSystemRuntime/Private/Widgets/PSOverlayWidget.cpp
Outdated
Show resolved
Hide resolved
Source/ProgressionSystemRuntime/Private/Widgets/PSOverlayWidget.cpp
Outdated
Show resolved
Hide resolved
Source/ProgressionSystemRuntime/Private/Widgets/PSOverlayWidget.cpp
Outdated
Show resolved
Hide resolved
Source/ProgressionSystemRuntime/Public/Widgets/PSOverlayWidget.h
Outdated
Show resolved
Hide resolved
Source/ProgressionSystemRuntime/Private/Widgets/PSOverlayWidget.cpp
Outdated
Show resolved
Hide resolved
Source/ProgressionSystemRuntime/Private/Widgets/PSOverlayWidget.cpp
Outdated
Show resolved
Hide resolved
…ore time variable for better naming
JanSeliv
pushed a commit
that referenced
this pull request
Mar 22, 2025
* added skins overlay showup whenever user switch to locked skins * removed nesting * renamed i to beter name * renamed bool to correct naming * simplified if else * removed unused include * added const * moved logic to separet methode to make easier to maintain even method * simplified bool checkers and improved code readability * reverted fade changed since they are arriving in the next PR * Refactored current show locked fade overlay logic (#64) * refactoring * renamed the properties for shorter names * drastically improved comments * fixed code style issues * code style updates * made const elements * simplified if statement * added pointer handle * added additional state for the FadeOut to return early, renamed one more time variable for better naming * simplified same verification * improved naming to be clear * fixed ticket with state none * fixed issue with skins get unlocked accidentally * added ability to have instant switch for skin change but keep animation for plat change * added const * added blueprint protected, reformatted code * added missing comments on functiom * simplified isCurrentSpot function * added const fucntion and made it blueprintPrue * refactored to calculate the previous character on the fly instead of caching value * fixed boolNaming to CamelCase * extra space removed * revisited namings to better explain what is it * Updated references after refactoring
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
421240175-428bddf6-7075-4c6e-bec1-fd10a4e928c0.mp4