Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

failFast needs to be within requireEncoding tag #271

Closed
henrik242 opened this issue Sep 18, 2023 · 1 comment · Fixed by #291
Closed

failFast needs to be within requireEncoding tag #271

henrik242 opened this issue Sep 18, 2023 · 1 comment · Fixed by #291
Assignees

Comments

@henrik242
Copy link

henrik242 commented Sep 18, 2023

The documentation shows failFast within the configuration tag:

            <configuration>
              <rules>
                <requireEncoding>
                  <encoding>UTF-8</encoding>
                  <includes>src/main/resources/**,src/test/resources/**</includes>
                </requireEncoding>
              </rules>
              <fastFail>false</fastFail>
            </configuration>

This doesn't work. failFast needs to be with requireEncoding to show all failing files:

            <configuration>
              <rules>
                <requireEncoding>
                  <encoding>UTF-8</encoding>
                  <includes>src/main/resources/**,src/test/resources/**</includes>
                  <fastFail>false</fastFail>
                </requireEncoding>
              </rules>
            </configuration>
@slawekjaranowski
Copy link
Member

You right - PR are welcome

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants