-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support for JAXB 3 #175
Support for JAXB 3 #175
Conversation
This is a must-have i'd say |
Can someone merge this PR ? I didn't find any other maven plugin alternative for JAXB 3.0.0, it would be really useful for a lot of people, I think, to have this release. |
@adamretter I will merge it. However, push snapshot to oss.sonartype is problematic these days. Thanks |
Thanks @dantran. Will it be possible to get a release out too? |
I am running into a dilemma, it seems I need to use the latest mojo-parent(60) in order to deploy and release, however, doing so breaks maven site At the same time, windows build has one unit test failure jaxb3 support fully backward compatible with jaxb2? |
@adamretter I am able to fix the maven site issue |
@adamretter jaxb3 support fully backward compatible with jaxb2? |
@dantran What is the issue that you are seeing? If you can point me to it and tell me how to reproduce, then I might have some ideas |
@dantran I found a single failing test on Windows which is @dantran I just sent a PR to fix the Windows failing test - #178 |
I am afraid that we really needed a release and so I forked the project to https://github.com/evolvedbinary/mojohaus-jaxb-maven-plugin and added the Windows fix #178 and released it here - https://search.maven.org/search?q=com.evolvedbinary.maven.mojohaus I am hoping it is a short-lived fork and we can replace it with an updated "official" MojoHaus release when that is ready. |
@adamretter Thank you much! I was waiting for a long time to this release and nothing happened! |
@cristiammercado thanks and you are welcome |
@adamretter I staged 3.0.0 and called our a vote at https://groups.google.com/g/mojohaus-dev/c/1Sdm-4PKjLs please help testing the staged artifact. and add your vote there Thanks for works on jaxb 3.0 support. |
Thanks @dantran I will take a look and see what I can do. |
@dantran It says I don't have permissions to contribute to that Google Group, and I can't find a sign-up link. Any ideas? |
do you see this ? https://groups.google.com/g/mojohaus-dev |
@dantran got it, thanks! |
This finishes the work that was started by @rlfnb in #166 to update the plugin for JAXB 3, so that all tests and integration tests now pass. Dependencies have also been bought up to date.
It does strike me however that the plugin is named
jaxb2-maven-plugin
and so perhaps we might want to fork this tojaxb3-maven-plugin
rather than just merging the PR to this repository?Thoughts?
Closes #165
Closes #166