Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for JAXB 3 #175

Merged
merged 7 commits into from
Jan 17, 2021
Merged

Support for JAXB 3 #175

merged 7 commits into from
Jan 17, 2021

Conversation

adamretter
Copy link
Contributor

@adamretter adamretter commented Dec 4, 2020

This finishes the work that was started by @rlfnb in #166 to update the plugin for JAXB 3, so that all tests and integration tests now pass. Dependencies have also been bought up to date.

It does strike me however that the plugin is named jaxb2-maven-plugin and so perhaps we might want to fork this to jaxb3-maven-plugin rather than just merging the PR to this repository?

Thoughts?

Closes #165
Closes #166

@dizzzz
Copy link

dizzzz commented Dec 9, 2020

This is a must-have i'd say

@Chavjoh
Copy link

Chavjoh commented Jan 15, 2021

Can someone merge this PR ? I didn't find any other maven plugin alternative for JAXB 3.0.0, it would be really useful for a lot of people, I think, to have this release.

@dantran
Copy link
Contributor

dantran commented Jan 17, 2021

@adamretter I will merge it. However, push snapshot to oss.sonartype is problematic these days. Thanks

@dantran dantran merged commit 2f5dd20 into mojohaus:master Jan 17, 2021
@adamretter
Copy link
Contributor Author

Thanks @dantran. Will it be possible to get a release out too?

@dantran
Copy link
Contributor

dantran commented Jan 17, 2021

@adamretter

I am running into a dilemma, it seems I need to use the latest mojo-parent(60) in order to deploy and release, however, doing so breaks maven site

At the same time, windows build has one unit test failure

jaxb3 support fully backward compatible with jaxb2?

@dantran
Copy link
Contributor

dantran commented Jan 18, 2021

@adamretter I am able to fix the maven site issue

@dantran
Copy link
Contributor

dantran commented Jan 21, 2021

@adamretter jaxb3 support fully backward compatible with jaxb2?

@adamretter
Copy link
Contributor Author

adamretter commented Jan 21, 2021

@dantran What is the issue that you are seeing? If you can point me to it and tell me how to reproduce, then I might have some ideas

@adamretter
Copy link
Contributor Author

adamretter commented Jan 26, 2021

@dantran I found a single failing test on Windows which is FileSystemUtilitiesTest#validateRelativizingPaths(). However, having done some investigation it appears that this test was failing even before my PR.

@dantran I just sent a PR to fix the Windows failing test - #178
Is there anything further I can do to assist in getting a release of this out?

@adamretter
Copy link
Contributor Author

I am afraid that we really needed a release and so I forked the project to https://github.com/evolvedbinary/mojohaus-jaxb-maven-plugin and added the Windows fix #178 and released it here - https://search.maven.org/search?q=com.evolvedbinary.maven.mojohaus

I am hoping it is a short-lived fork and we can replace it with an updated "official" MojoHaus release when that is ready.

@cristiammercado
Copy link

cristiammercado commented Jan 29, 2021

@adamretter Thank you much! I was waiting for a long time to this release and nothing happened!

@adamretter
Copy link
Contributor Author

@cristiammercado thanks and you are welcome

@dantran dantran added this to the Release 3.0 milestone Jan 31, 2021
@dantran
Copy link
Contributor

dantran commented Jan 31, 2021

@adamretter I staged 3.0.0 and called our a vote at https://groups.google.com/g/mojohaus-dev/c/1Sdm-4PKjLs

please help testing the staged artifact. and add your vote there

Thanks for works on jaxb 3.0 support.

@adamretter
Copy link
Contributor Author

Thanks @dantran I will take a look and see what I can do.

@adamretter
Copy link
Contributor Author

@dantran It says I don't have permissions to contribute to that Google Group, and I can't find a sign-up link. Any ideas?

@dantran
Copy link
Contributor

dantran commented Feb 2, 2021

do you see this ? https://groups.google.com/g/mojohaus-dev

@adamretter
Copy link
Contributor Author

@dantran got it, thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prepare jaxb2-maven-plugin for jakarta.xml.bind
6 participants