Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support creating tag lists for non java files #12

Closed
juliangp opened this issue Dec 18, 2019 · 2 comments · Fixed by #56
Closed

Support creating tag lists for non java files #12

juliangp opened this issue Dec 18, 2019 · 2 comments · Fixed by #56
Labels
enhancement Improving an existing feature. java Pull requests that update Java code

Comments

@juliangp
Copy link
Contributor

I would like to be able to create tag lists for mixed java/scala projects.

Please see the pull request here: #11

Thanks in advance!

@bmarwell bmarwell added enhancement Improving an existing feature. java Pull requests that update Java code labels Jan 17, 2022
@bmarwell
Copy link
Contributor

@juliangp I gave it some thought, and I think I would like to do a more common <includes> and <excludes> approach than the sourcetypes you suggested in #11. The reason is that with your approach:

  1. it is impossible to include files without extension.
  2. It is more common (nowadays)

Examples:

WDYT?

If you don't have time and still need it, I can do it for a 3.1.0 release, so we can go on with the 3.0.0 release.

@juliangp
Copy link
Contributor Author

@bmarwell I will create a PR for you today

juliangp added a commit to juliangp/taglist-maven-plugin that referenced this issue Jan 18, 2022
juliangp added a commit to juliangp/taglist-maven-plugin that referenced this issue Jan 18, 2022
juliangp added a commit to juliangp/taglist-maven-plugin that referenced this issue Jan 18, 2022
bmarwell added a commit that referenced this issue Jan 20, 2022
 - style updates
 - remove pom/java comment (issue exists)
bmarwell pushed a commit that referenced this issue Jan 21, 2022
bmarwell added a commit that referenced this issue Jan 21, 2022
 - style updates
 - remove pom/java comment (issue exists)
bmarwell added a commit that referenced this issue Jan 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Improving an existing feature. java Pull requests that update Java code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants