Improve speed of versions:resolve-ranges in case parents contain many version properties #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-schutte-ohra-nl thanks for PR What title of PR should be ... ? Please consider that it will be used in release notes, so what we want to say for users? |
m-schutte-ohra-nl
changed the title
There was a problem hiding this comment.
I prefer groovy than bsh ... but it is also ok
slawekjaranowski
approved these changes
Aug 27, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1121
If 'includeProperties' is null, use it to restrict the properties that are considered in the resolve-ranges mojo to those from the current project. Otherwise, user will normally have included only a subset of those.
Also added an it to cover the situation in #367 as this wasn't covered yet and led me to believe at first that setting 'includeParent' to false in the VersionPropertiesMapRequest was enough.