Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#717: Changing the property prefix to mojohaus.versions #718

Closed
wants to merge 1 commit into from

Conversation

andrzejj0
Copy link
Contributor

No description provided.

@slawekjaranowski
Copy link
Member

I'm not sure if we should brake compatibility for old properties in simply way.

We rename two old properties:

  • maven.version.rules.serverId
  • maven.version.rules

Probably such properties not widely used, but in this case I would prefer one PR for one property to show such change in releases notes.

@andrzejj0
Copy link
Contributor Author

Yeah, that was my concern as well... And there's no easy way of providing an alias to a property, besides creating a second parameter.

Should we just leave these two parameters as they are and just rename the third one?

@slawekjaranowski
Copy link
Member

I don't expect a big impacts on users - I think that when we show it in release notes will be acceptable - parameter name for configuration are not changed

@andrzejj0
Copy link
Contributor Author

I've just noticed this:

@Parameter( property = "versions.skip" )

Should we go for the versions. prefix then?

@pzygielo
Copy link
Contributor

Should we go for the versions. prefix then?

👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants