Caching update information in reports to increase performance #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzejj0
force-pushed
the
reports-add-caching
branch
from
f48f93c to
1940218
Compare
|
@slawekjaranowski please review |
andrzejj0
force-pushed
the
reports-add-caching
branch
from
1940218 to
f1c31a8
Compare
andrzejj0
force-pushed
the
reports-add-caching
branch
from
f1c31a8 to
0c66cc5
Compare
slawekjaranowski
approved these changes
Oct 12, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some duplication of calls to
AbstractVersionDetails::getOldestUpdateand similar: e.g. the same information is retrieved first during the rendering of the "Overview" section to gather aggregate information, then the call is repeated to render update details.