Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#754: Use Modello for XML reports (also fixes #755) #757

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

andrzejj0
Copy link
Contributor

Use Modello for XML report generation instead of writing reports using StringBuilder. This is less error-prone and we can easily generate the XML Schema for the reports.

This also fixes #755

@andrzejj0 andrzejj0 changed the title #754: Use Modello for XML reports #754: Use Modello for XML reports (also fixes #755) Oct 14, 2022
@andrzejj0 andrzejj0 force-pushed the xml-renderers-modello branch from df87c37 to 1deae1e Compare October 14, 2022 13:58
Comment on lines +24 to +25
xsd.namespace="http://mojo.codehaus.org/versions-maven-plugin/dependency-updates-report/1.0.0"
xsd.targetNamespace="http://mojo.codehaus.org/versions-maven-plugin/dependency-updates-report/1.0.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about namespase like:

https://www.mojohaus.org/VERSIONS/DEPENDENCY-UPDATES-REPORT/1.0.0

similar to Maven xsd:
http://maven.apache.org/xsd/

@slawekjaranowski slawekjaranowski added this to the 2.13.0 milestone Oct 15, 2022
@slawekjaranowski slawekjaranowski linked an issue Oct 15, 2022 that may be closed by this pull request
@slawekjaranowski slawekjaranowski added dependencies Pull requests that update a dependency file enhancement and removed dependencies Pull requests that update a dependency file labels Oct 16, 2022
@slawekjaranowski slawekjaranowski merged commit 5824363 into mojohaus:master Oct 16, 2022
@andrzejj0 andrzejj0 deleted the xml-renderers-modello branch October 16, 2022 10:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: XML reports are serialized incorrectly Use Modello for XML report renderers
2 participants