Always use Google maps to share position #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gmaps links are like an universal geo: URI, most platform uses these link to open their own GPS app (iOS/Android/Browsers)
valldrac
force-pushed
the
molly-6.19
branch
3 times, most recently
from
c982e1d to
fa7f630
Compare
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gmaps links are unfortunately like an universal geo: URI, all platforms use these links to open their own GPS app (iOS/Android/Browsers). Even OSM apps on Android use it.
This solution is probably better than #184 since it makes position sharing more usable for everyone.
Another solution would be to have the 2 links (OSM and Gmap) but it is against signal UX, keeping things easy. Then users would have to say 'click on the second link'.