Added an option to not show v2 PIN reminders. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valldrac
requested changes
Feb 26, 2020
app/src/main/java/org/thoughtcrime/securesms/util/TextSecurePreferences.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/thoughtcrime/securesms/conversationlist/ConversationListFragment.java
Outdated
Show resolved
Hide resolved
|
Thanks for the PR. Please review my comments. |
valldrac
approved these changes
Feb 27, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extra option is shown when a v2 PIN set and it prevents the weekly reminder to show.
One small issue: if a reminder is already shown you have to exit Molly (locking is not necessary, just exit the main activity) and reopen it for the reminder to go away. I did not fix this because it would complicate the code a lot for an option that is probably set-once and forget.