Skip to content

chore: move refresh dbs button up to be inline #6929

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

betsybutton
Copy link
Contributor

@betsybutton betsybutton commented May 15, 2025

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)
image image

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

This change responds to lots of user feedback we're heard that the refresh button should not be buried under the ... menu.

Dependents

N/a

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@betsybutton betsybutton changed the title chore: move refresh button up to be inline chore: move refresh dbs button up to be inline May 16, 2025
@lerouxb lerouxb added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label May 16, 2025
@lerouxb
Copy link
Contributor

lerouxb commented May 16, 2025

You need either a ticket number in the title or the no-title-validation tag on the PR for the Check PR Title task to succeed, btw.

CI seems to be very red right now, probably due to https://www.electronjs.org/blog/ecosystem-node-22/

@gribnoysup
Copy link
Collaborator

Merged main to see if there are any actual test failures

@Anemy
Copy link
Member

Anemy commented May 28, 2025

Looks like some related test failures around how we used to open the menu and click refresh to perform this action:

await browser.selectConnectionMenuItem(

@betsybutton let us know if you'd like someone else to take a look or if you're up for it!

@betsybutton
Copy link
Contributor Author

@Anemy Honestly, I don't think I'll be able to get back to this soon 😢 Any of you would probably be able to clean it up a lot faster than me. Would be great for someone to pick this up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants