Skip to content

feat(NODE-6773): add multiple collinfo option #70

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Feb 27, 2025
Merged

Conversation

nbbeeken
Copy link
Collaborator

@nbbeeken nbbeeken commented Feb 19, 2025

Description

What is changing?

  • Upgrade to libmongocrypt 1.13.
  • Add option to enable mongocrypt_setopt_enable_multiple_collinfo.
Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Enables multiple collection info support for $lookup aggregations

Calls mongocrypt_setopt_enable_multiple_collinfo to enable the setting

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

addaleax
addaleax previously approved these changes Feb 20, 2025
@nbbeeken nbbeeken marked this pull request as ready for review February 21, 2025 15:48
@nbbeeken nbbeeken requested a review from a team as a code owner February 21, 2025 15:48
@addaleax addaleax dismissed their stale review February 21, 2025 16:18

See Bailey's comment

@nbbeeken nbbeeken changed the title feat(NODE-6773): enable multiple collinfo option feat(NODE-6773): add multiple collinfo option Feb 21, 2025
@baileympearson baileympearson self-assigned this Feb 24, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 24, 2025
@baileympearson baileympearson merged commit 67dcf70 into main Feb 27, 2025
41 checks passed
@baileympearson baileympearson deleted the NODE-6773-update branch February 27, 2025 17:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants