DOCSP-45176: Run a command #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-ruby ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rachel-mack
approved these changes
Jan 15, 2025
|
|
||
| * - ``ok?`` | ||
| - Returns ``true`` if the command succeeded, and ``false`` otherwise. If the ``ok?`` | ||
| method returns ``false``The driver raises a ``Mongo::Error::OperationFailure`` . |
There was a problem hiding this comment.
Suggested change
| method returns ``false``The driver raises a ``Mongo::Error::OperationFailure`` . | |
| method returns ``false``, the driver raises a ``Mongo::Error::OperationFailure`` . |
jamis
approved these changes
Jan 17, 2025
Comment on lines
87
to
89
| You can set a read preference for the command execution by passing a | ||
| ``ReadPreference`` instance as a parameter to ``command``, as | ||
| shown in the following code: |
There was a problem hiding this comment.
The example given after this paragraph does not use a ReadPreference instance, instead passing a hash of read preference options. Maybe the paragraph could be adjusted something like:
Suggested change
| You can set a read preference for the command execution by passing a | |
| ``ReadPreference`` instance as a parameter to ``command``, as | |
| shown in the following code: | |
| You can set a read preference for the command execution by passing the | |
| ``:read`` option to the ``command`` method, as shown in the following code: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45176
Staging Links
Self-Review Checklist