fix(NODE-3662): error checking to make sure that ObjectId results in object with correct properties #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 26, 2021 13:33
…s in object with correct properties
…and add test for invalid id type
gjchong25
added
Primary Review
dariakp
added
the
Primary Review
dariakp
requested changes
Oct 26, 2021
…tructor to test for errors
dariakp
requested changes
Oct 27, 2021
There was a problem hiding this comment.
Thank you for adding the extra test cases, just a small suggestion for improving the effectiveness of the tests here. Also, since we are fixing a bug, the title of the PR should start with fix(NODE-3662) ... so that it will be picked up and listed in our automatically generated docs (refactor and test type commits are skipped in the docs).
gjchong25
changed the title
dariakp
added
Team Review
nbbeeken
requested changes
Oct 27, 2021
dariakp
requested changes
Oct 27, 2021
nbbeeken
requested changes
Oct 29, 2021
dariakp
requested changes
Nov 1, 2021
nbbeeken
approved these changes
Nov 2, 2021
dariakp
approved these changes
Nov 2, 2021
test/node/object_id_tests.js
Outdated
| expect(Buffer.from([0, 0, 0, 1])).to.deep.equal(a.id.slice(0, 4)); | ||
| expect(1000).to.equal(a.getTimestamp().getTime()); | ||
|
|
||
| var b = new ObjectId(); | ||
| let b = new ObjectId(); |
There was a problem hiding this comment.
This and the declaration in L10 can be a const. One somewhat weird thing in JS that you might not be aware of is that const does not mean "unchanging", it only means "unchanging reference", so even though we set a property on b in L14, as far as JS is concerned, b is still a const, because its reference is unchanged.
dariakp
approved these changes
Nov 2, 2021
gjchong25
added a commit
that referenced
this pull request
Nov 2, 2021
…object with correct properties (#467)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tightens the logic within the ObjectId constructor to make sure that inputs to the constructor are of the proper types, otherwise throws a TypeError. Tests to make sure that invalid inputs have an error thrown (rather than creating a "broken" ObjectId object with no 'id' property, for instance) are added.