Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(NODE-4887): serializeInto does not check for the presence of a toBSON method for values in Map entries #555

Merged
merged 3 commits into from
Jan 9, 2023
Merged

fix(NODE-4887): serializeInto does not check for the presence of a toBSON method for values in Map entries #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
931c59f
fix(NODE-4887): WIP fix for maps
W-A-James Jan 5, 2023
6de6fdb
test(NODE-4887): Add test for toBSON
W-A-James Jan 6, 2023
6f927fa
test(NODE-4877): Change test name
W-A-James Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/parser/serializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,11 @@ export function serializeInto(

// Get the entry values
const key = entry.value[0];
const value = entry.value[1];
let value = entry.value[1];

if (typeof value?.toBSON === 'function') {
value = value.toBSON();
}

// Check the type of the value
const type = typeof value;
Expand Down
9 changes: 9 additions & 0 deletions test/node/to_bson_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,15 @@ describe('toBSON', function () {
const sizeNestedToBSON = BSON.calculateObjectSize({ a: [0] });
expect(sizeNestedToBSON).to.equal(33);
});

it('uses toBSON on values contained in a map', () => {
const map = new Map();
map.set('a', 100);

const serializedData = BSON.serialize(map);
const deserializedData = BSON.deserialize(serializedData);
expect(deserializedData).to.have.property('a', 'hello number');
});
});

it('should use toBSON in calculateObjectSize', () => {
Expand Down