Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[3.8] Laravel 8 support #2108

Merged
merged 7 commits into from
Sep 30, 2020
Merged

[3.8] Laravel 8 support #2108

merged 7 commits into from
Sep 30, 2020

Conversation

divine
Copy link
Contributor

@divine divine commented Sep 21, 2020

  • Bump dependencies
  • Update test
  • Remove PHP 7.2 from github ci
  • Remove phpunit ^8.4
  • Migrate phpunit configuration ("Your XML configuration validates against a deprecated schema.")

For all changes please check https://laravel.com/docs/8.x/upgrade


  • Queue The retryAfter method hasn't changed
  • Queue timeoutAt property isn't used directly within this library
use Illuminate\Queue\Jobs\DatabaseJob;
class MongoJob extends DatabaseJob
  • Queue the allOnQueue() / allOnConnection() methods isn't used directly within this library

- Bump dependencies
- Update test
- Remove PHP 7.2 from github ci
- Remove phpunit ^8.4
- Migrate phpunit configuration "Your XML configuration validates against a deprecated schema."
Add 3.8.x release for Laravel 8.
@divine divine marked this pull request as draft September 21, 2020 22:12
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #2108 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2108      +/-   ##
============================================
+ Coverage     86.90%   87.01%   +0.11%     
  Complexity      664      664              
============================================
  Files            33       33              
  Lines          1573     1556      -17     
============================================
- Hits           1367     1354      -13     
+ Misses          206      202       -4     
Impacted Files Coverage Δ Complexity Δ
src/Jenssegers/Mongodb/Relations/MorphTo.php 83.33% <100.00%> (ø) 6.00 <0.00> (ø)
src/Jenssegers/Mongodb/Eloquent/Model.php 93.63% <0.00%> (-1.28%) 83.00% <0.00%> (ø%)
src/Jenssegers/Mongodb/Eloquent/Builder.php 87.93% <0.00%> (-0.21%) 22.00% <0.00%> (ø%)
src/Jenssegers/Mongodb/Relations/EmbedsMany.php 97.14% <0.00%> (-0.11%) 45.00% <0.00%> (ø%)
src/Jenssegers/Mongodb/Queue/MongoQueue.php 100.00% <0.00%> (ø) 10.00% <0.00%> (ø%)
...rc/Jenssegers/Mongodb/Eloquent/HybridRelations.php 93.58% <0.00%> (+5.94%) 34.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8211268...f1cce13. Read the comment docs.

@divine
Copy link
Contributor Author

divine commented Sep 21, 2020

Only left is https://laravel.com/docs/8.x/upgrade#seeder-factory-namespaces

@Smolevich should we move to new seeder factory namespaces in our tests as well?

@divine divine marked this pull request as ready for review September 21, 2020 22:20
@divine divine requested a review from Smolevich September 21, 2020 22:37
Smolevich
Smolevich previously approved these changes Sep 22, 2020
@Smolevich
Copy link
Contributor

Only left is https://laravel.com/docs/8.x/upgrade#seeder-factory-namespaces

@Smolevich should we move to new seeder factory namespaces in our tests as well?

I think that we can change this mechanism later

@Smolevich
Copy link
Contributor

@jenssegers we drop php 7.2 from matrix because Laravel supports php > 7.3, can you off php 7.2 from matrix cache

huangdijia
huangdijia previously approved these changes Sep 27, 2020
Copy link

@huangdijia huangdijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mongodb mongodb deleted a comment from huangdijia Sep 27, 2020
@divine
Copy link
Contributor Author

divine commented Sep 27, 2020

+1

@huangdijia please kindly stop spamming.

@IsaevDimka
Copy link

@divine when it's released ?

@Smolevich
Copy link
Contributor

@divine when it's released ?

When maintainer(@jenssegers) resolved error with CI

@divine
Copy link
Contributor Author

divine commented Sep 29, 2020

@Smolevich I think that only collaborators could see this message:

image


@IsaevDimka basically as @Smolevich said we can't merge it* because CI isn't finished and owner of this library needs to disable 7.2 from matrix cache.

* We don't have enough permissions to do so.

@divine divine dismissed stale reviews from huangdijia and Smolevich via 1c4726b September 30, 2020 06:48
Smolevich
Smolevich previously approved these changes Sep 30, 2020
@Smolevich Smolevich merged commit a362df4 into master Sep 30, 2020
@divine divine deleted the l8 branch September 30, 2020 09:18
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants