-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[3.8] Laravel 8 support #2108
[3.8] Laravel 8 support #2108
Conversation
- Bump dependencies - Update test - Remove PHP 7.2 from github ci
- Remove phpunit ^8.4 - Migrate phpunit configuration "Your XML configuration validates against a deprecated schema."
Add 3.8.x release for Laravel 8.
Codecov Report
@@ Coverage Diff @@
## master #2108 +/- ##
============================================
+ Coverage 86.90% 87.01% +0.11%
Complexity 664 664
============================================
Files 33 33
Lines 1573 1556 -17
============================================
- Hits 1367 1354 -13
+ Misses 206 202 -4
Continue to review full report at Codecov.
|
Only left is https://laravel.com/docs/8.x/upgrade#seeder-factory-namespaces @Smolevich should we move to new seeder factory namespaces in our tests as well? |
I think that we can change this mechanism later |
@jenssegers we drop php 7.2 from matrix because Laravel supports php > 7.3, can you off php 7.2 from matrix cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@huangdijia please kindly stop spamming. |
@divine when it's released ? |
When maintainer(@jenssegers) resolved error with CI |
@Smolevich I think that only collaborators could see this message: @IsaevDimka basically as @Smolevich said we can't merge it* because CI isn't finished and owner of this library needs to disable 7.2 from matrix cache. * We don't have enough permissions to do so. |
Breaking change in minor release laravel/framework#34531
[3.8] Laravel 8 support
"Your XML configuration validates against a deprecated schema."
)For all changes please check https://laravel.com/docs/8.x/upgrade