Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[3.8] Fix getRelationQuery breaking changes #2263

Merged
merged 4 commits into from
May 27, 2021

Conversation

divine
Copy link
Contributor

@divine divine commented May 27, 2021

Closes #2262

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #2263 (924c285) into master (a9b432b) will increase coverage by 1.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2263      +/-   ##
============================================
+ Coverage     87.12%   88.12%   +1.00%     
+ Complexity      670      664       -6     
============================================
  Files            33       33              
  Lines          1584     1566      -18     
============================================
  Hits           1380     1380              
+ Misses          204      186      -18     
Impacted Files Coverage Δ
src/Relations/HasMany.php 66.66% <ø> (+33.33%) ⬆️
src/Relations/HasOne.php 66.66% <ø> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b432b...924c285. Read the comment docs.

@Smolevich Smolevich merged commit 6aa6ad1 into mongodb:master May 27, 2021
@realtebo
Copy link

Thanks for this fix, you saved my life

@divine divine deleted the fix-getrelation branch May 27, 2021 08:04
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
[3.8] Fix getRelationQuery breaking changes
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getRelationQuery incompatible
4 participants