Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add validate instaceof Model and fix current in sync method for Hybrid relation #2276

Open
wants to merge 8 commits into
base: 5.x
Choose a base branch
from

Conversation

juniohyago
Copy link
Contributor

No description provided.

@divine
Copy link
Contributor

divine commented Jun 26, 2021

Hello,

Add tests, please.

Thanks!

@juniohyago
Copy link
Contributor Author

Hello,
tests ok
thanks

@divine
Copy link
Contributor

divine commented Jul 2, 2021

Hello,

Tests are failing, also fix php-cs-fixer suggestion.

Thanks!

@juniohyago
Copy link
Contributor Author

hello,
I haven't found a model for many to many hybrids, do I need to create this?

@juniohyago
Copy link
Contributor Author

Hello,
Tests are ok now,
Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2021

Codecov Report

Merging #2276 (26e77f6) into master (6aa6ad1) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2276      +/-   ##
============================================
+ Coverage     88.12%   88.38%   +0.26%     
- Complexity      664      665       +1     
============================================
  Files            33       33              
  Lines          1566     1567       +1     
============================================
+ Hits           1380     1385       +5     
+ Misses          186      182       -4     
Impacted Files Coverage Δ
src/Relations/BelongsToMany.php 87.25% <100.00%> (+1.11%) ⬆️
src/Eloquent/Model.php 94.26% <0.00%> (+0.63%) ⬆️
src/Eloquent/HybridRelations.php 96.15% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa6ad1...26e77f6. Read the comment docs.

@alcaeus alcaeus changed the base branch from 4.1 to 5.x September 12, 2024 08:54
@alcaeus alcaeus requested a review from a team as a code owner September 12, 2024 08:54
@alcaeus alcaeus requested review from alcaeus and removed request for a team September 12, 2024 08:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants