Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handling single model in sync method #2648

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

hans-thomas
Copy link
Contributor

@hans-thomas hans-thomas commented Oct 21, 2023

Hi, sync and syncWithoutDetaching methods now accept a single model as an argument.
Related issue (fix #2395) and PR (fix #2396).

@hans-thomas hans-thomas marked this pull request as ready for review October 21, 2023 13:48
@hans-thomas
Copy link
Contributor Author

@GromNaN Can you please review this PR?

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@GromNaN GromNaN added this to the 4.1 milestone Nov 2, 2023
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hans-thomas

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syncWithoutDetaching() isn't accepting a single model as an argument
2 participants