Fix support for subqueries using the query builder #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Feb 1, 2024
docs/query-builder.txt
Outdated
|
|
||
| User::where('results', 'elemMatch', ['gte' => 80, 'lt' => 85])->get(); | ||
|
|
||
| A sub-query builder can be to apply filter on documents. |
There was a problem hiding this comment.
This reads a little rough. Consider:
Suggested change
| A sub-query builder can be to apply filter on documents. | |
| A closure can be used to create more complex sub-queries. |
Ping @jmikola in case he has a better suggestion.
There was a problem hiding this comment.
@jmikola any opinion on this wording?
There was a problem hiding this comment.
No objections. Sorry for the delayed response, as I wasn't monitoring mentions in this repo.
GromNaN
commented
Feb 2, 2024
alcaeus
approved these changes
Feb 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2700
Checklist