[fix] Prevent exception when connection is closed #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanderMuller
changed the title
GromNaN
approved these changes
May 22, 2024
|
Thank you @SanderMuller |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the MongoDB connection disconnects, it currently unsets the connection property altogether. This causes the following exception when trying to use a MongoDB connection afterwards:
Prevent Undefined property: MongoDB\Laravel\Connection::$connectionThis PR sets the connection (client) to
nullinstead of usingunset().Unfortunately there doesn't seem to be a reconnector configured by default, otherwise
$connection->reconnect()could be used, but this has no effect right now. Could be a good next step for someone to implement.It's possible that this issue only occurs when using Database Transactions (that's my use case. Didn't get any exceptions locally despite long periods of heavy load, but on our Atlas instance it is getting this exception a real lot)
Checklist