Remove @mixin on Model class
#2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
May 28, 2024
| @@ -48,7 +48,6 @@ | |||
| use function strcmp; | |||
| use function var_export; | |||
|
|
|||
| /** @mixin Builder */ | |||
There was a problem hiding this comment.
I noted there were some other solutions proposed in larastan/larastan#1940 (comment) but I assume they're not something we can fix independently within this package.
Merged
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2923
It seems that
@mixinis too naive, doesn't support all dynamic methods and doesn't translate return types correctly.Checklist