PHPORM-180 Keep createOrFirst in 2 commands to simplify implementation #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested review from
alcaeus and
jmikola
and removed request for
alcaeus
3 tasks
|
Unfortunately, that doesn't solve the nested transaction issue reported initially #2720. |
jmikola
reviewed
May 29, 2024
GromNaN
force-pushed
the
PHPORM-180-revert
branch
2 times, most recently
from
65418d2 to
181f2de
Compare
GromNaN
force-pushed
the
PHPORM-180-revert
branch
from
181f2de to
b082fd1
Compare
jmikola
reviewed
May 29, 2024
jmikola
approved these changes
May 30, 2024
| * @param array $values The attributes to insert if no matching record is found | ||
| */ | ||
| public function createOrFirst(array $attributes = [], array $values = []): Model | ||
| public function firstOrCreate(array $attributes = [], array $values = []) |
There was a problem hiding this comment.
I'm not actually suggesting this, but it's amusing to me that this entire method body could be reduced to:
return (clone $this)->where($attributes)->first() ??
$this->getConnection()->getSession()?->isInTransaction()
? $this->create(array_merge($attributes, $values))
: $this->createOrFirst($attributes, $values);
There was a problem hiding this comment.
Sure, but it won't help me to use xdebug's step-by-step debugger.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-180
Alternative to #2980
Revert optimisation from #2742 in order to keep all the processes from Eloquent and simplify maintenance.
The main feature difference is that it's requiring a unique index whereas my previous implementation was only using the filter "attributes". This new implementation is closer to Laravel's implementation, it only removes the nested transaction and catch the MongoDB exception instead of the PDO exception.
Checklist