PHPORM-211 Fix unsetting property in embedded model #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Jul 18, 2024
Comment on lines
+397
to
+402
| if (str_starts_with($key, '$')) { | ||
| assert(is_array($value), 'Update operator value must be an array.'); | ||
| $results[$key] = static::getUpdateValues($value, $prepend); | ||
| } else { | ||
| $results[$prepend . $key] = $value; | ||
| } |
There was a problem hiding this comment.
Before, the incorrect update was:
{
$set: {
"address.$.updated_at": Date(...),
"address.$.$unset": {
"city": true,
}
}
}After, it becomes:
{
"$unset": {
"address.$.city": true,
},
"$set": {
"address.$.updated_at": Date(...),
}
}Field names starting with a $ are not supported, that's why we are sure there will not be 2 levels of recursion.
GromNaN
commented
Jul 18, 2024
Comment on lines
-30
to
-35
| Book::truncate(); | ||
| Item::truncate(); | ||
| Role::truncate(); | ||
| Client::truncate(); | ||
| Group::truncate(); | ||
| Photo::truncate(); |
There was a problem hiding this comment.
Side change: This models are not used in this test class.
alcaeus
reviewed
Jul 19, 2024
Co-authored-by: Andreas Braun <git@alcaeus.org>
alcaeus
approved these changes
Jul 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-211
Checklist