Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

PHPORM-216 Remove $collection setting from DocumentModel and Connecti… #3104

Merged
merged 1 commit into from
Aug 26, 2024
Merged

PHPORM-216 Remove $collection setting from DocumentModel and Connecti… #3104

merged 1 commit into from
Aug 26, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Aug 19, 2024 •
edited
Loading

Fix PHPORM-216

Follow #3064

  • Remove setting Model::$collection. To customize the collection name, use Laravel's $table property
  • Remove method Connection::collection(), use Connection::table() instead
  • Remove method Schema::collection(), use Schema::table() instead

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

@GromNaN GromNaN added this to the 5.0 milestone Aug 19, 2024
@GromNaN GromNaN requested a review from a team as a code owner August 19, 2024 16:53
@GromNaN GromNaN requested a review from mana2-bot August 19, 2024 16:53
@GromNaN GromNaN force-pushed the PHPORM-216 branch 2 times, most recently from 4aa5024 to c49f601 Compare August 20, 2024 17:15
@GromNaN GromNaN requested review from alcaeus and removed request for mana2-bot August 21, 2024 12:50
alcaeus
alcaeus approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@GromNaN
PHPORM-216 Remove $collection setting from DocumentModel and Connecti…
fed3d26 
…on::collection(). Use $table and Connection::table() instead
@GromNaN GromNaN merged commit 9c1146c into mongodb:5.0 Aug 26, 2024
26 checks passed
@GromNaN GromNaN deleted the PHPORM-216 branch August 26, 2024 15:38
@GromNaN GromNaN added the feature label Sep 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @alcaeus