-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
DOCSP-42794: Laravel Passport #3113
DOCSP-42794: Laravel Passport #3113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single remark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few things!
|
||
Laravel Passport is an OAuth 2.0 server implementation that offers | ||
API authentication for Laravel applications. Use Laravel Passport if | ||
your application requires OAuth2 support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: maybe you can link to a resource describing Oauth and/or passport?
'web' => [ | ||
'driver' => 'session', | ||
'provider' => 'users', | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this other entry default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the web entry is added automatically
docs/user-authentication.txt
Outdated
'driver' => 'session', | ||
'provider' => 'users', | ||
], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: remove space (will need to adjust emphasized lines)
docs/user-authentication.txt
Outdated
For example, the following code overrides the default ``Laravel\Passport\AuthCode`` | ||
model class by defining a ``MongoDB\Laravel\Passport\AuthCode`` class and including | ||
the ``DocumentModel`` trait: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: possibly clearer explanation:
Something like
For example, the following code overrides the default ``Laravel\Passport\AuthCode`` | |
model class by defining a ``MongoDB\Laravel\Passport\AuthCode`` class and including | |
the ``DocumentModel`` trait: | |
The following example code extends the default ``Laravel\Passport\AuthCode`` | |
model class when defining a ``MongoDB\Laravel\Passport\AuthCode`` class and includes | |
the ``DocumentModel`` trait: |
protected $primaryKey = '_id'; | ||
protected $keyType = 'string'; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: does the user need to create models for each of the listed classes? If so, that should be more clear in a note or something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah each one needs a custom model. I changed the wording of the paragraph below (line 246) to clarify that, lmk if it's clear enough
docs/user-authentication.txt
Outdated
You can now use Laravel Passport and MongoDB in your application. For more information, see | ||
`Laravel Passport <https://laravel.com/docs/{+laravel-docs-version+}/passport>`__ in the | ||
Laravel documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: recommend moving the link up to the intro
You can now use Laravel Passport and MongoDB in your application. For more information, see | |
`Laravel Passport <https://laravel.com/docs/{+laravel-docs-version+}/passport>`__ in the | |
Laravel documentation. | |
The, you can use Laravel Passport with MongoDB in your application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
JIRA - https://jira.mongodb.org/browse/DOCSP-42794
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/laravel/DOCSP-42794-passport/user-authentication/#laravel-passport
Checklist