Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DOCSP-43172: Remove DatabaseTokenRepository class #3130

Merged
merged 5 commits into from
Sep 6, 2024
+10 −0
Merged

DOCSP-43172: Remove DatabaseTokenRepository class #3130

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5130011
DOCSP-43172: Remove DatabaseTokenRepository class
norareidy Aug 30, 2024
f95ecc3
JT feedback
norareidy Sep 3, 2024
fb1744f
edit
norareidy Sep 3, 2024
0af9fb3
JT feedback 2
norareidy Sep 4, 2024
f0b1b5c
Merge remote-tracking branch 'upstream/5.0' into DOCSP-43172-remove-d…
norareidy Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions docs/upgrade.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,17 @@ version releases that introduced them. When upgrading library versions,
address all the breaking changes between your current version and the
planned upgrade version.

.. _laravel-breaking-changes-v5.x:

Version 5.x Breaking Changes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This library version introduces the following breaking changes:

- Removes support for the ``Auth\DatabaseTokenRepository`` class. Instead,
use the ``Illuminate\Queue\Failed\DatabaseFailedJobProvider`` class and
specify a connection to MongoDB.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mixed the 2 classes that are removed.

Suggested change
- Removes support for the ``Auth\DatabaseTokenRepository`` class. Instead,
use the ``Illuminate\Queue\Failed\DatabaseFailedJobProvider`` class and
specify a connection to MongoDB.
- Remove the ``MongoDB\Laravel\Auth\DatabaseTokenRepository`` class. Instead,
use the default ``Illuminate\Auth\Passwords\DatabaseTokenRepository`` class and
specify a connection to MongoDB.
- Remove the ``MongoDB\Laravel\Queue\Failed\MongoFailedJobProvider`` class. Instead,
use the default ``Illuminate\Queue\Failed\DatabaseFailedJobProvider`` class and
specify a connection to MongoDB.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another ticket for the MongoFailedJobProvider class, but happy to include that in this PR since it's quick


.. _laravel-breaking-changes-v4.x:

Version 4.x Breaking Changes
Expand Down
Loading