DOCSP-43159: QB returns objects #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be documented in the upgrade guide. This is a major breaking change. |
norareidy
approved these changes
Sep 5, 2024
…3159-query-builder-returns-object
GromNaN
reviewed
Sep 6, 2024
docs/upgrade.txt
Outdated
Comment on lines
84
to
87
| DB::table('accounts') | ||
| ->where('name', 'Anita Charles') | ||
| ->first() | ||
| ->balance |
There was a problem hiding this comment.
You could highlight the change with a diff (not sure if diffs are correctly colorized in the docs):
Suggested change
| DB::table('accounts') | |
| ->where('name', 'Anita Charles') | |
| ->first() | |
| ->balance | |
| $document = DB::table('accounts') | |
| ->where('name', 'Anita Charles') | |
| ->first(); | |
| - $document['balance']; | |
| + $document->balance; |
Preview:
$document = DB::table('accounts')
->where('name', 'Anita Charles')
->first();
- $document['balance'];
+ $document->balance;There was a problem hiding this comment.
The only way we can demonstrate this is by using code comments. I can make that change though!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds documentation to note that QB returns results as objects instead of arrays in v5
https://jira.mongodb.org/browse/DOCSP-43159
Staging
upgrade guide
Checklist