Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DOCSP-44610: fix php links #3185

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

rustagir
Copy link
Contributor

fixes link to php extension installation instructions

Checklist

  • Add tests and ensure they pass

@rustagir rustagir requested a review from a team as a code owner October 24, 2024 17:56
@rustagir rustagir requested a review from norareidy October 24, 2024 17:56
@github-actions github-actions bot added the docs label Oct 24, 2024
Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion about the directive

@@ -35,7 +35,7 @@ to a Laravel web application.

{+odm-long+} requires the {+php-extension+} to manage MongoDB
connections and commands.
Follow the `Installing the MongoDB PHP Driver with PECL <https://www.php.net/manual/en/mongodb.installation.pecl.php>`__
Follow the `Installing the MongoDB PHP Driver with PECL <https://www.php.net/manual/en/mongodb.installation.php>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: you can also use the :php: directive

Suggested change
Follow the `Installing the MongoDB PHP Driver with PECL <https://www.php.net/manual/en/mongodb.installation.php>`__
Follow the :php:`Installing the MongoDB PHP Driver with PECL <mongodb.installation>`

@rustagir rustagir enabled auto-merge (squash) October 24, 2024 19:28
@rustagir rustagir merged commit 4123eff into mongodb:4.8 Oct 24, 2024
26 checks passed
This was referenced Oct 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants