Fix generation of SARIF reports #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
fix-sarif-report-generation
branch
from
1edb598 to
6bfda1b
Compare
GromNaN
force-pushed
the
fix-sarif-report-generation
branch
from
6bfda1b to
5b337b4
Compare
GromNaN
approved these changes
Nov 6, 2024
This was referenced Nov 6, 2024
Merged
Merged
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up in #3192. When PHPStan adds an error about unmatched exclusion patterns,
getLine()returnsnull, which violates the schema. To work around this, we only add a region to an error if a line is present.