Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DOCSP-45411: qb options #3208

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Nov 19, 2024

https://jira.mongodb.org/browse/DOCSP-45411
Adds documentation for setting options on query builder

staging

Checklist

  • Add tests and ensure they pass

@rustagir rustagir requested a review from a team as a code owner November 19, 2024 16:21
@rustagir rustagir requested a review from norareidy November 19, 2024 16:21
@github-actions github-actions bot added the docs label Nov 19, 2024
Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion!

@@ -81,6 +86,33 @@ of the Quick Start.
To perform read and write operations by using the query builder, import the
``Illuminate\Support\Facades\DB`` facade and compose your query.

.. _laravel-options-query-builder:

Set Query-Level Options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I think it makes more sense to have the "Retrieve Matching Documents" section come before this one, since "Set Query-Level Options" sets options for where(), described in "Retrieve Matching Documents". Maybe you could move this section before "Modify Query Results"?

@rustagir rustagir requested a review from GromNaN November 19, 2024 18:56
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustagir rustagir merged commit 0af5611 into mongodb:4.8 Nov 20, 2024
26 checks passed
This was referenced Nov 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants