PHPORM-287 Split Atlas Search CI workflow #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
PHPORM-287
branch
5 times, most recently
from
a0636f2 to
97dd373
Compare
GromNaN
changed the title
GromNaN
commented
Jan 15, 2025
|
|
||
| - name: "Run tests" | ||
| run: | | ||
| export MONGODB_URI="mongodb://127.0.0.1:27017/?directConnection=true" |
There was a problem hiding this comment.
Related to #3205 (comment)
| sleep 1 | ||
| done | ||
| until docker exec --tty mongodb mongosh 127.0.0.1:27017 --eval "db.createCollection('connection_test') && db.getCollection('connection_test').createSearchIndex({mappings:{dynamic: true}})"; do | ||
| until docker exec --tty mongodb $MONGOSH_BIN --eval "db.runCommand({ ping: 1 })"; do |
There was a problem hiding this comment.
Host removed, related to #3205 (comment)
| fi | ||
| ./vendor/bin/phpunit --coverage-clover coverage.xml | ||
| export MONGODB_URI="mongodb://127.0.0.1:27017/?replicaSet=rs" | ||
| ./vendor/bin/phpunit --coverage-clover coverage.xml --exclude-group atlas-search |
There was a problem hiding this comment.
By filtering on the group, there is less tests, and I don't get crashes in GitHub Actions.
jmikola
approved these changes
Jan 15, 2025
.github/workflows/build-ci-atlas.yml
Outdated
| os: | ||
| - "ubuntu-latest" | ||
| mongodb: | ||
| - "Atlas" |
There was a problem hiding this comment.
I don't see any reference to matrix.mongodb in this file. Is this needed for something else? If not, I think we can just remove the mongodb matrix axis.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-287