-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
DOCSP-47950: Fix all operator section #3308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one possible addition - your call
docs/query-builder.txt
Outdated
documents that have a ``cast`` field containing all the specified | ||
array values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this makes it clearer or not?
documents that have a ``cast`` field containing all the specified | |
array values: | |
documents that have a ``cast`` field array containing all the specified | |
array values: |
docs/query-builder.txt
Outdated
@@ -869,7 +869,8 @@ Contains All Fields Example | |||
|
|||
The following example shows how to use the ``all`` query | |||
operator with the ``where()`` query builder method to match | |||
documents that contain all the specified fields: | |||
documents that have a ``cast`` field containing all the specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you choose an other field name, as casts
has as special meaning in Laravel (its a reserved word in the model). That could lead to confusion: https://laravel.com/docs/12.x/eloquent-mutators#attribute-casting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, changed to "writers"
JIRA - https://jira.mongodb.org/browse/DOCSP-47950
Staging - https://deploy-preview-173--docs-laravel.netlify.app/query-builder/#contains-all-fields-example
Checklist