Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DOCSP-47950: Fix all operator section #3308

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Mar 5, 2025

@norareidy norareidy requested a review from a team as a code owner March 5, 2025 19:29
@norareidy norareidy requested a review from rustagir March 5, 2025 19:29
@norareidy norareidy changed the base branch from 5.x to 5.2 March 5, 2025 19:29
@github-actions github-actions bot added the docs label Mar 5, 2025
Copy link

@rachel-mack rachel-mack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one possible addition - your call

Comment on lines 872 to 873
documents that have a ``cast`` field containing all the specified
array values:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this makes it clearer or not?

Suggested change
documents that have a ``cast`` field containing all the specified
array values:
documents that have a ``cast`` field array containing all the specified
array values:

@@ -869,7 +869,8 @@ Contains All Fields Example

The following example shows how to use the ``all`` query
operator with the ``where()`` query builder method to match
documents that contain all the specified fields:
documents that have a ``cast`` field containing all the specified
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you choose an other field name, as casts has as special meaning in Laravel (its a reserved word in the model). That could lead to confusion: https://laravel.com/docs/12.x/eloquent-mutators#attribute-casting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, changed to "writers"

@norareidy norareidy requested a review from GromNaN March 5, 2025 20:57
@norareidy norareidy merged commit 89772e2 into mongodb:5.2 Mar 6, 2025
62 checks passed
@norareidy norareidy deleted the DOCSP-47950-all-fix branch March 6, 2025 15:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants