CSHARP-5598: Fix CoreServerSessionPool.IsAboutToExpire test #1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
requested review from
papafe and
BorisDog
and removed request for
a team and
papafe
sanych-sun
commented
May 26, 2025
| public void IsAboutToExpire_should_never_expire_in_load_balancing_mode() | ||
| { | ||
| var subject = CreateSubject(); | ||
| var mockedCluster = new TestCluster(ClusterType.LoadBalanced); |
There was a problem hiding this comment.
In scope of CSOT I've updated IClusterInternal interface, instead of mirroring the changes here, I've decided to remove local implementation by using Moq (CreateSubject method already constructing that mock)
sanych-sun
commented
May 26, 2025
| var mockedCluster = new TestCluster(ClusterType.LoadBalanced); | ||
| var mockedServerSessionPool = new CoreServerSessionPool(mockedCluster); | ||
| var mockSession = new Mock<ICoreServerSession>(); | ||
| var lastUsedAt = DateTime.UtcNow.AddSeconds(1741); |
There was a problem hiding this comment.
This line of code is incorrect, we should add negative seconds to make session looks expired (see line 231 before the changes).
BorisDog
approved these changes
May 27, 2025
| [InlineData(ClusterType.LoadBalanced, null, false)] | ||
| [InlineData(ClusterType.LoadBalanced, 1741, false)] | ||
| [InlineData(ClusterType.LoadBalanced, 1739, false)] | ||
| public void IsAboutToExpire_should_return_expected_result(ClusterType clusterType, int? lastUsedSecondsAgo, bool expectedResult) |
There was a problem hiding this comment.
nit: rename expectedResult to isAboutToExpire?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.