CSHARP-5512: Convert LINQ-related tests to use fixtures #1710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
changed the title
|
Assigned |
rstam
requested changes
Jun 27, 2025
| @@ -15,6 +15,7 @@ | |||
| <NoWarn> | |||
| 1701;1702; <!--https://github.com/dotnet/roslyn/issues/19640--> | |||
| CA1724; <!--The type name Model conflicts in whole or in part with the namespace name. Change either name to eliminate the conflict. (https://docs.microsoft.com/visualstudio/code-quality/ca1724-type-names-should-not-match-namespaces)--> | |||
| CA1714; <!-- Flags enums should have plural names --> | |||
There was a problem hiding this comment.
Are you sure you want to disable this warning project-wide?
There was a problem hiding this comment.
We have to either suppress the warning or rename enums as recommended. I do remember we had similar problem with class named "Model" and we decided to suppress the warning instead of renaming (see line above the commented). But I'm OK with renaming if in this case we do not want to suppress the warning.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another batch of LINQ-related tests converted to use Fixtures.