Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CLOUDP-300821: [AtlasCLI] Update help text of commands with --file flags to clarify we will ignore not documented fields #3683

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

jeroenvervaeke
Copy link
Collaborator

Proposed changes

  • Added note about unsupported fields to all commands using file.Load
  • Flyby: fix internal/cli/organizations/invitations/update.go, --file was not a registered flag

Jira ticket: CLOUDP-300821

@jeroenvervaeke jeroenvervaeke requested review from a team as code owners February 24, 2025 12:43
@github-actions github-actions bot added need-doc-review Improvements or additions to documentation, will be reviewed by the docs team atlascli labels Feb 24, 2025
Copy link
Contributor

APIx Bot :bowtie:: a message has been sent to Docs Slack channel 🚀.

@@ -56,7 +56,7 @@ Options
* - -f, --file
- string
- false
- Path to an optional JSON configuration file that defines invitation settings. To learn more about invitation configuration files for the Atlas CLI, see https://XXX.
- Path to an optional JSON configuration file that defines invitation settings. Note: Unsupported fields in the JSON file are ignored. To learn more about invitation configuration files for the Atlas CLI, see https://XXX.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

see https://XXX.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I've removed the URL for now, since there's no documentation yet.
I also created a DOCSP ticket to create this page: https://jira.mongodb.org/browse/DOCSP-47853

Copy link
Contributor

Coverage Report 📈

Branch Commit Coverage
master 65a4449 37.8%
CLOUDP-300821 a09beba 37.8%
Difference 0%

Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jvincent-mongodb jvincent-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeroenvervaeke jeroenvervaeke merged commit 4c17545 into master Feb 24, 2025
22 checks passed
@jeroenvervaeke jeroenvervaeke deleted the CLOUDP-300821 branch February 24, 2025 17:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
atlascli need-doc-review Improvements or additions to documentation, will be reviewed by the docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants