Skip to content

bugfix: make setAnnotation do what the signature implies #1253

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

nammn
Copy link
Collaborator

@nammn nammn commented Mar 30, 2023

  • fix json readiness probe formatting.
  • fix setAnnotation(object) to only set annotations to given object and not replace the whole object with the one backed by kubernetes. This was bugprone, especially since most of the places were relying on using calling setAnnotation(object.DeepCopy).
  • fixes mongodConfig.DeepCopy since it was not null pointer safe.

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@nammn nammn changed the title make annotation do what the signature implies make setAnnotation do what the signature implies Mar 30, 2023
@nammn nammn changed the title make setAnnotation do what the signature implies bugfix: make setAnnotation do what the signature implies Mar 30, 2023
@nammn nammn marked this pull request as ready for review March 30, 2023 12:34
Copy link
Collaborator

@lsierant lsierant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM!

@nammn nammn merged commit 0c29c92 into master Mar 31, 2023
@nammn nammn deleted the fix-duplication-copy branch March 31, 2023 08:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants