Skip to content

Fixing the make deploy command #626

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Fixing the make deploy command #626

merged 1 commit into from
Jul 9, 2021

Conversation

killian2k
Copy link
Contributor

Make deploy was broken on the master branch.
Found a way to fix it with the help of @chatton

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you signed all of your commits?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests pass. We can merge this fix to fix master, and then revisit the most correct way to use kustomize in the future.

@killian2k killian2k merged commit 0256e7a into master Jul 9, 2021
@killian2k killian2k deleted the fix_make_deploy branch July 9, 2021 10:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants