MONGOID-5839 Fix eager-loading from STI subclasses #5934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the root of a query is an STI subclass (e.g. `Subclass.all`) AND the query tries to eager load (`includes`) another association, the eager load was failing because it was looking for inverse associations using the STI subclass name, instead of the class at the root of the hierarchy.
|
I just tried and the fix work with Mongoid 8.0.8. Thanks. I had to change because the model I used didn't include |
|
Any update on this? |
|
@stanley90 sorry, some illness and a long weekend left this one in a bit of limbo. I hope to push it across the finish line (and backport it as necessary) in the next couple of days. |
comandeo-mongo
approved these changes
Jan 21, 2025
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Jan 22, 2025
If the root of a query is an STI subclass (e.g. `Subclass.all`) AND the query tries to eager load (`includes`) another association, the eager load was failing because it was looking for inverse associations using the STI subclass name, instead of the class at the root of the hierarchy.
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Jan 22, 2025
If the root of a query is an STI subclass (e.g. `Subclass.all`) AND the query tries to eager load (`includes`) another association, the eager load was failing because it was looking for inverse associations using the STI subclass name, instead of the class at the root of the hierarchy.
jamis
added a commit
that referenced
this pull request
Jan 22, 2025
If the root of a query is an STI subclass (e.g. `Subclass.all`) AND the query tries to eager load (`includes`) another association, the eager load was failing because it was looking for inverse associations using the STI subclass name, instead of the class at the root of the hierarchy.
jamis
added a commit
that referenced
this pull request
Jan 22, 2025
If the root of a query is an STI subclass (e.g. `Subclass.all`) AND the query tries to eager load (`includes`) another association, the eager load was failing because it was looking for inverse associations using the STI subclass name, instead of the class at the root of the hierarchy.
|
Hi, me again. It's been fixed for a while, but could we get a release? It's biting me quite a bit. Thx |
|
8.0.9 has been released. Patch releases for 8.1.x and 9.0.x are forthcoming (probably tomorrow). |
|
8.1.9 and 9.0.5 are released now, as well: https://www.mongodb.com/community/forums/t/mongoid-maintenance-releases-now-available-9-0-5-8-1-9-8-0-9/311172 |
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the root of a query is an STI subclass (e.g.
Subclass.all) AND the query tries to eager load (includes) another association, the eager load was failing because it was looking for inverse associations using the STI subclass name, instead of the class at the root of the hierarchy.