feat(NODE-6773): add support for $lookup on encrypted collections #4427

New issue

Jump to bottom

Merged

baileympearson merged 17 commits into main from NODE-6774-fle-lookup

Feb 28, 2025

Contributor

nbbeeken commented Feb 19, 2025 •

edited

Loading

Description

What is changing?

adds tests for lookup support

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Add support for $lookup on encrypted collections

Starting in the upcoming MongoDB server 8.1, the aggregation stage $lookup can now be used with clients configured for automatic encryption after upgrading to mongodb-client-encryption@>=6.3.0! 🔒 🎉

Double check the following

Ran npm run check:lint script
Self-review completed using the steps outlined here
PR title follows the correct format: type(NODE-xxxx)[!]: description
- Example: feat(NODE-1234)!: rewriting everything in coffeescript
Changes are covered by tests
New TODOs have a related JIRA ticket

nbbeeken mentioned this pull request

feat(NODE-6773): add multiple collinfo option mongodb-js/mongodb-client-encryption#70

Merged

5 tasks

nbbeeken force-pushed the NODE-6774-fle-lookup branch 2 times, most recently from 813223f to ffb01de Compare

February 21, 2025 15:26

nbbeeken marked this pull request as ready for review

February 21, 2025 15:53

nbbeeken requested a review from a team as a code owner

February 21, 2025 15:53

Contributor Author

nbbeeken commented Feb 21, 2025

Will update the bindings when they are available, we can still start reviewing what is in here in the meantime

baileympearson changed the title ~~feat(NODE-6774): add support for $lookup on encrypted collections~~ feat(NODE-6773): add support for $lookup on encrypted collections

baileympearson requested changes

View reviewed changes

Contributor

baileympearson left a comment

There are pending spec test changes from Maxim, I'll re-review the tests when Kevin has updated the prose tests in his PR.

src/client-side-encryption/auto_encrypter.ts Outdated Show resolved Hide resolved

src/client-side-encryption/state_machine.ts Show resolved Hide resolved

src/client-side-encryption/state_machine.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Show resolved Hide resolved

nbbeeken added the Primary Review label

nbbeeken assigned baileympearson

nbbeeken added the wip label

nbbeeken force-pushed the NODE-6774-fle-lookup branch 2 times, most recently from 715c23d to 4f797c9 Compare

February 25, 2025 20:06

nbbeeken added 11 commits

February 26, 2025 11:00


          feat(NODE-6774): support $lookup on encrypted collections

ec38479


          chore: add options

8ae4591


          test: multiple collection fails with a specific error when not enabled

57ba430


          chore: fixes

7e880c5


          chore: try fixing tests

7807e60


          chore: version filter

2abcda4


          chore: lint


          chore: wrong filter

47faa6f


          chore: more metadata

bfaf9b8


          chore: run on cryptd too

aedae0c


          chore: fix stub

e7ec664

nbbeeken force-pushed the NODE-6774-fle-lookup branch from 2384e2e to e7ec664 Compare

February 26, 2025 16:00

nbbeeken removed the wip label

addaleax reviewed

View reviewed changes

etc/bash_to_fish.mjs Outdated Show resolved Hide resolved


          chore: await append

d7089c2

baileympearson requested changes

View reviewed changes

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Show resolved Hide resolved

src/client-side-encryption/state_machine.ts Show resolved Hide resolved

src/client-side-encryption/state_machine.ts Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved


          chore: comments

227b904

nbbeeken commented

View reviewed changes

Contributor Author

nbbeeken left a comment

all comments should be addressed, but waiting for the release to publish so I can update our dev dep.

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Show resolved Hide resolved

src/client-side-encryption/state_machine.ts Show resolved Hide resolved

etc/bash_to_fish.mjs Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Outdated Show resolved Hide resolved

test/integration/client-side-encryption/client_side_encryption.prose.25.lookup.test.ts Show resolved Hide resolved

nbbeeken added 4 commits

February 27, 2025 13:22


          chore: bump package

a360870


          fix lock file

e371fd9


          fix: copy pasta

6cd6ea4


          chore: case 9 name and version

a0e96d2

baileympearson approved these changes

View reviewed changes

baileympearson added Team Review and removed Primary Review labels

baileympearson requested a review from addaleax

February 27, 2025 21:02

addaleax approved these changes

View reviewed changes

baileympearson merged commit 965b21a into main

30 checks passed

baileympearson deleted the NODE-6774-fle-lookup branch

February 28, 2025 13:49

github-actions bot mentioned this pull request

chore(main): release 6.14.0 [skip-ci] #4429

Merged

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels