Skip to content

fix(find): correctly translate timeout option into noCursorTimeout #2700

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2021
Merged

fix(find): correctly translate timeout option into noCursorTimeout #2700

merged 2 commits into from
Jan 19, 2021
+11 −7

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Jan 14, 2021 •
edited
Loading

The find command's timeout option was incorrectly being translated
into noCursorTimeout, this has been corrected to be !timeout.

NODE-2828

@emadum emadum marked this pull request as ready for review January 15, 2021 16:27
@emadum emadum requested review from nbbeeken and durran January 15, 2021 16:27
durran
durran approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emadum emadum merged commit e257e6b into 3.6 Jan 19, 2021
@emadum emadum deleted the NODE-2828/3.6/noCursorTimeout-fix branch January 19, 2021 21:11
@emadum emadum mentioned this pull request Jan 19, 2021
Merged
This was referenced Mar 9, 2021
Closed
Merged
Merged
Open
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emadum @durran @nbbeeken