feat(NODE-4898)!: aws credential providers now optional peerDependency #3497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
nbbeeken
reviewed
Dec 21, 2022
package.json
Outdated
| "saslprep": "^1.0.3" | ||
| }, | ||
| "peerDependencies": { | ||
| "@aws-sdk/credential-providers": "^3.186.0", |
There was a problem hiding this comment.
We may want to bump this to a higher number: v3.201.0 matches our nodejs version support level
There was a problem hiding this comment.
Good point - updated to 3.201.0
nbbeeken
approved these changes
Dec 21, 2022
nbbeeken
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes
@aws-sdk/credentials-provideran optional peer dependency.What is changing?
@aws-sdk/credentials-providera peer dependency with optional metadata.Is there new documentation needed for these changes?
Updates to migration doc.
What is the motivation for this change?
NODE-4898
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript