-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Created sink parallel execution (#624) #917
Conversation
That was the idea @MattSzm, I like it :) |
Will do a release after once merged, with all these recent mongo improvements |
@paualarco pr ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 🥇
Hi @paualarco I found
I've added the commit which fixes this. Fortunately, it was a problem with the test - not with the feature.
In the test case, we run these updates in parallel, so the results depend on the order.
I'm sorry for the mistake. But, we can be sure now, that these calls are made in parallel haha :D I can see there are still quite a few failing tests, but I don't think these are related to my change. |
mongodb/src/it/scala/monix/connect/mongodb/MongoSinkSuite.scala
Outdated
Show resolved
Hide resolved
@MattSzm yep there is some flaky test that need fixing... the failures are mainly related to random generators in combination with parallel tests. I will merge your pr after addressing my comment :) |
This is a proof of concept. Please validate the idea before I write all methods implementations/tests because for me the issue description can be interpreted in a couple of ways.