fix text param val converting to number #1796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue that can cause "text" param values to be converted from strings to numbers when reading a pset file.
Note that the fix introduces the opposite behavior: if a text param was intentionally set with a number value, it will now be converted to a string upon pset read. That scenario seems like an edge case to me and is probably not how text params were intended to be used, but could still be seen as a breaking change.
Script to reproduce issue: