-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Proposals better jsx mark up + some minor changes #19
Merged
monsonjeremy
merged 10 commits into
monsonjeremy:master
from
RaulCote:proposals-one-dark-better-jsx-dark-folding-dark-cursor-line
Oct 21, 2021
Merged
Proposals better jsx mark up + some minor changes #19
monsonjeremy
merged 10 commits into
monsonjeremy:master
from
RaulCote:proposals-one-dark-better-jsx-dark-folding-dark-cursor-line
Oct 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dark blue. Dark chosen color feels more in place with the regular background than the previous bg_highlight election.
…er and also much better when there is big line spacing set.
…n example JSDoc uses this to show depracated functions. The word wasn't getting selected previously.
… general boolean rule.
…t from React components.
…ual Studio Code onedark theme.
… as the predominant color than red.
Thanks for doing this, looks great! |
ful1e5
added a commit
to ful1e5/onedark.nvim
that referenced
this pull request
Dec 17, 2021
ful1e5
added a commit
to ful1e5/onedark.nvim
that referenced
this pull request
Dec 17, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I enjoy this colorscheme and plugin. Congrats for the work, really appreciate it. I open this PR to propose some small changes. Everything is explained on the commit messages but mostly I noticed the selected yellow was darker than the one used on the original onedark palette, this makes that the difference between orange / yellow was hard to see. Visual Studio Code dark them uses orange for HTML / React component attributes and yellow for the component name. This trick is pretty nice if you put italic for the attribute as well. That's the biggest change this PR propose. Find below the complete list.
Total Changes:
Now:
Before:
Feel free to apply changes to the PR if you don't like something. As said, these are proposals.